Comments on: MeioUpload Behavior 1.0.1 released!

By: Francis Rebouças

Francis Rebouças — Mon, 07 Sep 2009 17:20:27 +0000

Olá Vinicius.... Muito bom o seu behavior, sou um novo aventureiro do CakePHP, meu problema é o seguinte tenho que enviar uma lista de imagens de uma só vez pelo seu Behavior, por isso optei por um flash que cria a lista e as envia. As informações do arquivo fica em um $_FILES['Filedata'].

Meu Código: if (!empty($_FILES["Filedata"])) { $this->Imagem->create(); $this->data['Imagem']['imagem']['name'] = $_FILES['Filedata']['name']; $this->data['Imagem']['imagem']['type'] = $_FILES['Filedata']['type']; $this->data['Imagem']['imagem']['tmp_name'] = $_FILES['Filedata']['tmp_name']; $this->data['Imagem']['imagem']['error'] = $_FILES['Filedata']['error']; $this->data['Imagem']['imagem']['size'] = $_FILES['Filedata']['size']; $this->Imagem->save($this->data); }

Mas ele não resulta em nada. Não guarda nada em DB nem faz upload.

Obrigado

By: Vinicius Mendes

Vinicius Mendes — Mon, 27 Oct 2008 15:57:57 +0000

Hmm, good idea. I will do this. An option, if empty, don’t set permissions, else set the permission based in this string. The default will be it empty.

By: ADmad

ADmad — Sun, 26 Oct 2008 10:12:05 +0000

Setting fixed file permissions is not a good idea. Keep it configurable so that permissions can be set as required based on server needs.

By: Vinicius Mendes

Vinicius Mendes — Fri, 24 Oct 2008 02:08:55 +0000

Kanoa, thanks for the contribution, I will add this piece of code in the behavior.

By: kanoa

kanoa — Thu, 23 Oct 2008 16:42:11 +0000

Nice work, I was suffering from corrupted uploads on MAMP running OSX10.5.3. Inserting this block of code at line 636 to set the permissions of the uploaded file fixed the problem:

        // change the permissions of the uploaded file
        if(!chmod( $saveAs, 0644 ) ) {
            $model->validationErrors[$field] = 'Correct permissions could not be set on the uploaded file';
            return false;
        }

By: Vinicius Mendes

Vinicius Mendes — Thu, 23 Oct 2008 12:54:04 +0000

Hehe

thanks for the help. Fell free to make as many rouds as you want. I will see this invalidate function. And about the arrays, I will keep just the $default_validations, Since it merges both. I don't removed the $default_options['validations'] just to keep the backwards compatibility.

By: ADmad

ADmad — Thu, 23 Oct 2008 08:19:53 +0000

Comments round 2

In beforeSave when attempting to move uploaded file don’t set the error message directly to validationErrors array . Instead use the Model->invalidate function. Many people override this function for il8n and translate the message string first before setting to validationErrors.
Not important but declaring the default validation errors twice as $default_options['validations'] and as $default_validations seems a bit redundant. You can just have $default_options['validations'] and assign it to $default_validations in setup() if needed.

By: Vinicius Mendes

Vinicius Mendes — Sat, 11 Oct 2008 22:46:34 +0000

Thank's for the comment, I will take note of these suggestions and analyze the possibility of implementing them. I saw the Set::merge function a little while after publishing the behavior but already changed the code to use it, I will publish it soon.

About the validation, I'm thinking about changing some things in it. Maybe use the var $validate of the model to apply the validation rules. I think it is more related to the work the framework is doing.

And about the bakery, I'm trying to have time to do this. Anyway, thanks for the comment again.

By: ADmad

ADmad — Sat, 11 Oct 2008 14:25:00 +0000

Nice work. You have done a fine job improving upon the work of the previous authors. A few comments: - Didn’t core’s Set::merge work for you instead of you custom recursive merge function ? - Not that it matters much but I think a more appropriate location to merge validation rules with the model’s $validate would be beforeValidate callback. - You should submit this fine piece of work to the bakery. Its deserves more exposure

By: vbmendes

vbmendes — Mon, 06 Oct 2008 02:23:22 +0000

Obrigado pelo reconhecimento. Qualquer dúvida é só falar.